Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InstallCommand.php #830

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Update InstallCommand.php #830

merged 1 commit into from
Feb 2, 2024

Conversation

brunograndecom
Copy link
Contributor

The commit fixes the issue when FrankenPHP install fails when no-interaction flag is present.

Octane Version
2.3.2

Laravel Version
10.43.0

PHP Version
8.3

What server type are you using?
FrankenPHP

Steps To Reproduce
php artisan octane:install --server=frankenphp --no-interaction

fixes issue when frankenphp install fails when no-interaction flag is present
@brunograndecom
Copy link
Contributor Author

This is fixes this issue: #827

Copy link
Contributor

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@taylorotwell taylorotwell merged commit cbc9410 into laravel:2.x Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants