[13.x] Fix determining revoked records #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
I guess this solves the long outstanding #382 issue? If that's the case then we should definitely give this a go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how we determine if the specified record is revoked and adds integration tests for this.
Auth Code
If the given auth code does not exist (removed),
Bridge/AuthCodeRepository::isAuthCodeRevoked()returnsfalsemistakenly.Access Token
TokenRepository::isAccessTokenRevoked()is usingfindto determine if the given access token is revoked, this causes performance issue asTokenGaurdcallsfindtwice on every request.Refresh Token
RefreshTokenRepository::isRefreshTokenRevoked()also usesfindto determine if the given refresh token is revoked.