Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Force confidential PAT client #1761

Conversation

hafezdivandari
Copy link
Contributor

This PR forces personal access token grant to be confidential with the same approach as client credentials grant.

@driesvints
Copy link
Member

@hafezdivandari could perhaps help to explain why we'd want this?

@hafezdivandari
Copy link
Contributor Author

hafezdivandari commented Jul 1, 2024

sure @driesvints, the "Personal access token" grant and "Client Credential" grant must be confidential, other grants confidentiality are optional, as I mentioned above the client credentials grant already has this check, but the extended PAT grant does not, we do this check on the repository but it's a good practice to also check this on grant to be consistent with the oauth server.

@taylorotwell taylorotwell merged commit e1040f3 into laravel:13.x Jul 1, 2024
9 checks passed
@hafezdivandari hafezdivandari deleted the 13.x-force-confidential-personal-client branch July 2, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants