Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys to .gitignore #31

Closed
wants to merge 1 commit into from
Closed

Add keys to .gitignore #31

wants to merge 1 commit into from

Conversation

mdavis1982
Copy link

This PR adds the oauth keys to the .gitignore file if they don't already exist in it. This helps to prevent accidentally committing the keys to VCS.

@morloderex
Copy link
Contributor

morloderex commented Aug 20, 2016

@mdavis1982 The idea here is fine but the implimentation doesn't scale.
Forexample this prevents the package from beeing used by people without the grep or echo commands command avaliable to them.

@mdavis1982
Copy link
Author

@morloderex I'm not sure there's a supported system that doesn't have grep installed by default. It's certainly available on Linux and OS X, and the command will fail on Windows anyway because OpenSSL won't be installed by default.

@maximebeaudoin
Copy link

#33 sounds a better solution IMO.

@taylorotwell
Copy link
Member

Closing because of issues raised in thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants