[1.x] Ensure cache holds serialized values only #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82
The cache is currently holding onto scope object, which is a potential memory issue as all scope will now stay in memory until the end of the request.
It also means that the cache behaves unexpectedly for eloquent models when different instances of the same record are used, e.g.,
This fixes the memory issue and model reference issues by making sure the scope is serialized before it enters the cache.