-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended original InertiaJS props and method types into PrecognitionFormProps #77
Conversation
… Precognition useForm object result.
… Precognition useForm object result.
Thanks, @juanparati. I'm gonna review this one shortly. Appreciate your work here. |
Heym, @juanparati, thank you so much for pushing this along. I'm circling back to this now. I'm going to close this PR in favour of https://github.com/laravel/precognition/pull/88/files, simply because it is more recent and doesn't have any conflicts. Thank you again. |
@timacdonald : Thanks for take a look to my PR. I will look forward to precognition with Inertia 2 in the future. |
I was able to extend original InertiaJS props and methods types into the PrecognitionFormProps, so Typescript linters can provide scope over the original InertiaFormProps.
This method is better that proposed in #71 because it's not required to wrap methods for InertiaJS.
Advantages: