Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended original InertiaJS props and method types into PrecognitionFormProps #77

Closed
wants to merge 10 commits into from

Conversation

juanparati
Copy link

I was able to extend original InertiaJS props and methods types into the PrecognitionFormProps, so Typescript linters can provide scope over the original InertiaFormProps.

This method is better that proposed in #71 because it's not required to wrap methods for InertiaJS.

Advantages:

  • It will automatically inherit automatically all methods and props from different InertiaJS versions.
  • Easy to maintain, it only requires to write definitions for the resulted object of Precognition "useForm".

@timacdonald
Copy link
Member

Thanks, @juanparati. I'm gonna review this one shortly.

Appreciate your work here.

@timacdonald
Copy link
Member

Heym, @juanparati, thank you so much for pushing this along. I'm circling back to this now.

I'm going to close this PR in favour of https://github.com/laravel/precognition/pull/88/files, simply because it is more recent and doesn't have any conflicts.

Thank you again.

@juanparati
Copy link
Author

@timacdonald : Thanks for take a look to my PR. I will look forward to precognition with Inertia 2 in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants