[1.x] Ignore offline servers (continued) #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @JustinElst and @leventdev! I changed the config to be in seconds rather than minutes to be consistent with other config values like thresholds. I also removed the additional 30-second grace period, as I don't think it made as much sense with the config in seconds. |
jessarcher
approved these changes
Apr 16, 2024
timacdonald
reviewed
Apr 17, 2024
timacdonald
force-pushed
the
ignore-offline-servers
branch
6 times, most recently
from
95fe9de
to
2bd9d5e
Compare
|
API: <!-- Ignore servers after 600 seconds: -->
<livewire:pulse.servers cols="full" ignore-after="600" />
<!-- Ignore servers after 2 hours: -->
<livewire:pulse.servers cols="full" ignore-after="2 hours" /> |
timacdonald
force-pushed
the
ignore-offline-servers
branch
from
2bd9d5e
to
13720b1
Compare
timacdonald
approved these changes
May 1, 2024
timacdonald
force-pushed
the
ignore-offline-servers
branch
from
13720b1
to
3e5b95a
Compare
timacdonald
reviewed
May 1, 2024
Comment on lines
+74
to
+90
| /** | ||
| * Determine if the system should be ignored. | ||
| * | ||
| * @param object{ timestamp: int, key: string, value: string } $system | ||
| */ | ||
| protected function ignoreSystem(object $system): bool | ||
| { | ||
| if ($this->ignoreAfter === null) { | ||
| return false; | ||
| } | ||
|
|
||
| $ignoreAfter = is_numeric($this->ignoreAfter) | ||
| ? (int) $this->ignoreAfter | ||
| : CarbonInterval::createFromDateString($this->ignoreAfter)->totalSeconds; | ||
|
|
||
| return CarbonImmutable::createFromTimestamp($system->timestamp)->addSeconds($ignoreAfter)->isPast(); | ||
| } |
There was a problem hiding this comment.
I've called this ignoreSystem to differentiate it from our shared ignore method on the Ignores trait.
timacdonald
reviewed
May 1, 2024
Comment on lines
+19
to
+22
| use InteractsWithTime; | ||
|
|
||
| public int|string|null $ignoreAfter = null; | ||
|
|
There was a problem hiding this comment.
Livewire does not support DateInterval as a prop value, so I've excluded it from the type here.
Due to the way Livewire serializes values, we also cannot use now()->addSeconds(60) in the prop value.
jessarcher
approved these changes
May 1, 2024
|
Docs: laravel/docs#9622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request continues the work in [1.x] Ignore offline servers.
Thanks leventdev for starting this.
With this pull-request I wanted to complete the request made by in jessarcher in her comment.