Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Ensure first-party CSS is not overriden #378

Closed
wants to merge 1 commit into from

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented May 25, 2024

When a 3rd party card adds CSS it currently overrides existing CSS.

This sounds like a good thing and what we want, however due to the nature of Tailwind + the cascade, unwanted styling occurs.

For example, imagine a 3rd party card that uses the block class in Tailwind.

Because its .block { display: block } appears later in the order it will override undo some styling in the Pulse dashboard.

<button class="block dark:hidden">

This button will now always be visible.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@timacdonald timacdonald changed the title Ensure first-party CSS is not overriden [1.x] Ensure first-party CSS is not overriden May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant