Pagination with query callback broke pagination in last meilisearch version

[eliasjtg]

• Scout Version: 9.2.9
• Scout Driver: MeiliSearch 0.22
• Laravel Version:8.61.0
• PHP Version: 8.0.9
• Database Driver & Version: mysql 8.0.26-0ubuntu0.20.04.2

Description:

After upgrade meilisearch to 0.22 and upgrade meilisearch-php 0.19.1 the pagination is broken when queryCallback is provided.

Builder.php:398 return $totalCount that is always 0

When ->query() callback don't passed, pagination work perfectly

return Post::search($search)->paginate(5);

Steps To Reproduce:

Using query() reproduce the bug

return Post::search($search)->query(function($query) {
    $query->with('image');
})->paginate(5);

[driesvints]

Did you restart Meilisearch after upgrading?

[eliasjtg]

I'm using Homestead, i do vagrant reload --provision

This happening in my team and in production vps

[mmachatschek]

@eliasjtg can you post the result of return Post::search($search)->paginateRaw(5); so we can verify if this is an issue with scout or with meilisearch?

[eliasjtg]

A workaround was remove all ->query() callbacks and do the query in the model overriding queryScoutModelsByIds() function

[eliasjtg]

@eliasjtg can you post the result of return Post::search($search)->paginateRaw(5); so we can verify if this is an issue with scout or with meilisearch?

Working on it

[eliasjtg]

@mmachatschek

The output:

{
  "current_page": 1,
  "data": {
    "hits": [
      {
        "title": "My first post",
        "description": "It's my first post",
        "id": "1633101447865131000",
        "amount": "1",
        "city_id": 1633100293859345000,
        "category_id": 1633101141456362000,
        "sale": 1,
        "created_at": 1633101447,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My second post",
        "description": "My second post",
        "id": "1633101566197075000",
        "amount": "2",
        "city_id": 1633100293859345000,
        "category_id": 1633101141456362000,
        "sale": 1,
        "created_at": 1633101566,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My third post",
        "description": "My third post",
        "id": "1633101690961604000",
        "amount": "3",
        "city_id": 1633100293859345000,
        "category_id": 1633099535387689000,
        "sale": 1,
        "created_at": 1633101690,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633099495361081000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My fourth post",
        "description": "My fourth post",
        "id": "1633101737580754000",
        "amount": "4",
        "city_id": 1633100293859345000,
        "category_id": 1633099535387689000,
        "sale": 1,
        "created_at": 1633101737,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633099495361081000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My fifth post",
        "description": "My fifth post",
        "id": "1633101911172782000",
        "amount": "5",
        "city_id": 1633100293859345000,
        "category_id": 1633101767626905000,
        "sale": 1,
        "created_at": 1633101911,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      }
    ],
    "nbHits": 8,
    "exhaustiveNbHits": false,
    "query": "",
    "limit": 5,
    "offset": 0,
    "processingTimeMs": 0
  },
  "first_page_url": "https://api.myklick.local/app/post/home?query=&page=1",
  "from": 1,
  "last_page": 2,
  "last_page_url": "https://api.myklick.local/app/post/home?query=&page=2",
  "links": [
    {
      "url": null,
      "label": "Anterior",
      "active": false
    },
    {
      "url": "https://api.myklick.local/app/post/home?query=&page=1",
      "label": "1",
      "active": true
    },
    {
      "url": "https://api.myklick.local/app/post/home?query=&page=2",
      "label": "2",
      "active": false
    },
    {
      "url": "https://api.myklick.local/app/post/home?query=&page=2",
      "label": "Próximo",
      "active": false
    }
  ],
  "next_page_url": "https://api.myklick.local/app/post/home?query=&page=2",
  "path": "https://api.myklick.local/app/post/home",
  "per_page": 5,
  "prev_page_url": null,
  "to": 7,
  "total": 8
}

[eliasjtg]

if i do Post::search($search)->query(function($query) {})->paginateRaw(5);

{
  "current_page": 1,
  "data": {
    "hits": [
      {
        "title": "My first post",
        "description": "It's my first post",
        "id": "1633101447865131000",
        "amount": "1",
        "city_id": 1633100293859345000,
        "category_id": 1633101141456362000,
        "sale": 1,
        "created_at": 1633101447,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My second post",
        "description": "My second post",
        "id": "1633101566197075000",
        "amount": "2",
        "city_id": 1633100293859345000,
        "category_id": 1633101141456362000,
        "sale": 1,
        "created_at": 1633101566,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My third post",
        "description": "My third post",
        "id": "1633101690961604000",
        "amount": "3",
        "city_id": 1633100293859345000,
        "category_id": 1633099535387689000,
        "sale": 1,
        "created_at": 1633101690,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633099495361081000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My fourth post",
        "description": "My fourth post",
        "id": "1633101737580754000",
        "amount": "4",
        "city_id": 1633100293859345000,
        "category_id": 1633099535387689000,
        "sale": 1,
        "created_at": 1633101737,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633099495361081000
        ],
        "parent_category_fathers": null
      },
      {
        "title": "My fifth post",
        "description": "My fifth post",
        "id": "1633101911172782000",
        "amount": "5",
        "city_id": 1633100293859345000,
        "category_id": 1633101767626905000,
        "sale": 1,
        "created_at": 1633101911,
        "user_deleted": 0,
        "parent_category": null,
        "category_fathers": [
          1633101121627163000
        ],
        "parent_category_fathers": null
      }
    ],
    "nbHits": 8,
    "exhaustiveNbHits": false,
    "query": "",
    "limit": 5,
    "offset": 0,
    "processingTimeMs": 0
  },
  "first_page_url": "https://api.myklick.local/app/post/home?query=&page=1",
  "from": 1,
  "last_page": 1,
  "last_page_url": "https://api.myklick.local/app/post/home?query=&page=1",
  "links": [
    {
      "url": null,
      "label": "Anterior",
      "active": false
    },
    {
      "url": "https://api.myklick.local/app/post/home?query=&page=1",
      "label": "1",
      "active": true
    },
    {
      "url": null,
      "label": "Próximo",
      "active": false
    }
  ],
  "next_page_url": null,
  "path": "https://api.myklick.local/app/post/home",
  "per_page": 5,
  "prev_page_url": null,
  "to": 7,
  "total": 0
}

[driesvints]

This'll be in next week's release. Thanks @mmachatschek