Fix class names #33
Merged
Fix class names #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that causes this error
```
[Symfony\Component\Debug\Exception\FatalThrowableError]
Type error: Argument 1 passed to Laravel\Scout\SearchableScope::Laravel\Scout\{closure}() must be an ins
tance of Laravel\Scout\Builder, instance of Illuminate\Database\Eloquent\Builder given
```
Since an \Illuminate\Database\Eloquent\Builder doesn't extend Laravel\Scout\Builder to me the previous code will not work, these simple class name updates should fix the problem.
|
This should fix #27 too since i had the same problem and don't with the above change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that causes this error
Since an \Illuminate\Database\Eloquent\Builder doesn't extend Laravel\Scout\Builder to me the previous code will not work, these simple class name updates should fix the problem.