[9.x] Explicitly use map() or lazyMap().
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first created PR #439 it was under the impression we can use
QueryBuilder::cursor()and everything works the same. However new feedback from @JosephSilber there are some limitations to doing this, including eager loading.Changes
Engine::map()will useSearchable::getScoutModelsByIds()which will return eloquent collection.Engine::lazyMap()will useSearchable::queryScoutModelsByIds()which will return eloquent builder (where we can usecursor()).Limitation
I not sure if we are able to use
lazy()orlazyById()as far as I know since chunking the result as we need to sort by relevant search results.Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com