Collection Engine #488
Merged
Collection Engine #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
reviewed
Jun 28, 2021
Co-authored-by: Nuno Maduro <enunomaduro@gmail.com>
Co-authored-by: Joseph Silber <contact@josephsilber.com>
MatanYadaev
reviewed
Jun 28, 2021
| ->orderBy($builder->model->getKeyName(), 'desc') | ||
| ->get(); | ||
|
|
||
| $models = $models->values(); |
There was a problem hiding this comment.
Why ->values() is necessary?
| return $models; | ||
| } | ||
|
|
||
| $columns = array_keys($models->first()->toSearchableArray()); |
There was a problem hiding this comment.
Not sure if it's relevant, but toSearchableArray might be dynamic and depend on the model record. It might be better to execute it per record, and not only based on the first record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the weekend, I was hacking on something where I wanted to quickly use Scout without setting up any other external dependencies like Algolia or MeiliSearch.
I cooked up this quick driver that is intended for usage in local development and small staging environments only. It is not performant on large datasets and does not have robust fuzzy matching or anything. However, it is perfectly adequate in local development environments where you often don't have more than a couple hundred models.
However, this driver uses Eloquent's cursor method to retrieve filtered results and then uses
Str::containsagainst theLazyCollectionto match against all of the searchable columns. Note it is not possible to do those checks in the database because we do not know the data types of the columns and some RDBMS like Postgres will throw an error if you try to execute awhere likeclause against an integer column like an ID.So, in summary, this driver gives you a quick way to use Scout locally and get some generally sensible results from it just so you can continue building your application's search UI and functionality without worrying about the robustness of the search results themselves.
I decided against calling this a
databaseengine because it does not perform any sort of FULLTEXT column searching or use database search features. It iterates through aLazyCollectionof all models of a given type and filters their column's values against the query within PHP.