Call queryCallback in DatabaseEngine #591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
->query()
callback function on searches is helpful for things like eager loading relations, and is typically triggered viagetScoutModelsByIds
in engine implementations. Since the Database engine works directly with the models and does not call that method, I've added an explicit call toqueryCallback
when it's defined.In my limited testing, this allows things like the following to work consistently on several engines including MeiliSearch and Database without requiring any engine-specific end-user code changes:
It doesn't seem like that callback is documented so it may not be widely used, but since it is implemented consistently in the other official engines this seemed like a good contribution.