-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed numericFilters from AlgoliaEngine. #837
Removed numericFilters from AlgoliaEngine. #837
Conversation
The docs say |
Indeed, which is inconsistent with how meilisearch works (which supports everything). The docs also mention this
Which currently doesn't work |
@taylorotwell there is indeed a deeper underlying issue here with inconsistency between drivers. I feel like we have an opportunity here to align the different drivers more and at the same time make the Algolia search more powerful. Could we reconsider? |
I guess we'll give it a shot. Will have to roll it back if it breaks something. |
@driesvints we need to test this on a real Laravel application before it can be released. |
Thanks for merging this, if it does break something you can comment here, I will be happy to do a follow up! |
This reverts commit dadf49e.
@Boorinio unfortunately we had to revert this one as it's incompatible with https://github.com/algolia/scout-extended which still expects numericFilters. Can you re-attempt the PR to 11.x and also add an entry to the upgrade guide? |
Hopefully fixes
#831
@driesvints