Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Change default graph version, manually set desired version #408

Merged

Conversation

jdrzejb
Copy link
Contributor

@jdrzejb jdrzejb commented Nov 15, 2019

It changes default graph version to 3.3.

Also, it introduces a way of changing the default version. I'm still having second thoughts regarding this, as it might break functionality if facebook decides to change how object is accessed, and we will need a proper mapping between graph versions.

The usage I have in mind:

return Socialite::driver('facebook')->usingGraphVersion('v5.0')->redirect();

Let me know what do you think

@driesvints driesvints changed the title Change default graph version, manually set desired version [4.x] Change default graph version, manually set desired version Nov 15, 2019
@driesvints
Copy link
Member

Can you guarantee that updating the default API to 3.3 from 3.0 doesn't breaks anything?

@jdrzejb
Copy link
Contributor Author

jdrzejb commented Nov 15, 2019

There are no breaking changes in methods that are used in the package between v3.0 and v3.3.
I did not use it though. If you wish, I can test it live today when preparing social auth in my app.

https://developers.facebook.com/docs/graph-api/changelog/version3.3
https://developers.facebook.com/docs/graph-api/changelog/version3.2
https://developers.facebook.com/docs/graph-api/changelog/version3.1

@taylorotwell taylorotwell merged commit 220e127 into laravel:4.0 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants