Fix that multiple use of the same binding is only replaced once in the query #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohlerdominik
force-pushed
the
query-multi-binding
branch
from
9904ef8
to
b0ab537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named Query-bindings can be used multiple times in one query, but Telescope explicitly only replaces the first use of a binding. This is due to the fact that the preg_replace doesn't distinguish between unnamed parameters (where only the match hit must be replaced) and named parameters.
This makes rerunning queries in a console cumbersome, because it's always necessary to dump the bindings and replace further uses manually.