Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sockets instead of port 9000 #159

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

KorvinSzanto
Copy link
Contributor

This pr updates caddy and php-fpm to use a socket instead of port 9000. I figured if we were going to do this in the most straight forward way I might as well do the work. If you have different requirements I'd be happy to change my pr.

See #157 for reasoning behind this.

@drbyte
Copy link
Contributor

drbyte commented Sep 20, 2016

Works for me.

Downside is the need to touch all existing Caddy *.dev files to make the change ...

@KorvinSzanto
Copy link
Contributor Author

KorvinSzanto commented Sep 20, 2016

It's true this does require you run valet install again, not sure how to resolve that.

@adamwathan
Copy link
Contributor

valet install will regenerate all TLS Caddyfiles so it shouldn't be a huge deal unless people have customized those files by hand, which I don't think I would really recommend because changes like this are not super uncommon in this early stage of the project.

I'd like to improve the upgrade process because right now it's not uncommon to have to blow out your whole ~/.valet folder when anything significant changes, but sort of the best we have right now.

@adamwathan adamwathan merged commit 98af5e7 into laravel:master Sep 20, 2016
@drbyte
Copy link
Contributor

drbyte commented Sep 20, 2016

I'd like to improve the upgrade process because right now it's not uncommon to have to blow out your whole ~/.valet folder when anything significant changes, but sort of the best we have right now.

Ya, valet install always wipes out my custom dnsmasq.conf file :(

@drbyte drbyte mentioned this pull request Sep 20, 2016
@KorvinSzanto KorvinSzanto mentioned this pull request Sep 20, 2016
@KorvinSzanto KorvinSzanto deleted the feature/fpm_socket branch December 8, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants