Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test case #10

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Update test case #10

merged 1 commit into from
Jun 10, 2022

Conversation

webfansplz
Copy link
Contributor

@webfansplz webfansplz commented Jun 9, 2022 •
edited
Loading

The test case for prefixes the base with ASSET_URL only work in the production mode.

@taylorotwell taylorotwell marked this pull request as draft June 9, 2022 14:07
@webfansplz webfansplz marked this pull request as ready for review June 9, 2022 14:39
@webfansplz webfansplz marked this pull request as draft June 9, 2022 14:41
@webfansplz webfansplz marked this pull request as ready for review June 9, 2022 14:45
@taylorotwell
Copy link
Member

Marking as draft until @jessarcher reviews.

@taylorotwell taylorotwell marked this pull request as draft June 9, 2022 16:02
jessarcher
jessarcher approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@jessarcher jessarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jessarcher jessarcher marked this pull request as ready for review June 9, 2022 23:43
@jessarcher jessarcher merged commit 509e07c into laravel:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessarcher jessarcher jessarcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webfansplz @taylorotwell @jessarcher