Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display errors on exit #17

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Display errors on exit #17

merged 2 commits into from
Jun 15, 2022

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jun 15, 2022

This PR improves the exit and signal handling so that exception messages are output to the console.

It also ensures that the handlers are only bound once, as editing the vite.config.js file causes Vite to call this hooks again.

Fixes #15

Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jessarcher jessarcher merged commit 9b74d44 into main Jun 15, 2022
@jessarcher jessarcher deleted the graceful-exit branch June 15, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite dev server exits without message (fix in report)
2 participants