Skip to content

Conversation

driesvints
Copy link
Member

This pull request includes the changes for upgrading to Laravel 5.5. Feel free to commit any additional changes to the shift-4820 branch.

Before merging, you should:

  • Checkout the shift-4820 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the pre-commands fail, add --no-scripts)
  • Thoroughly test your application

If you would like more help with your upgrade, check out the human services from Laravel Shift. If you need to level-up your Git skills, check out Getting Git.

The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
@driesvints
Copy link
Member Author

⚠ Laravel 5.5 streamlined the Exception Handler. Shift was unable to upgrade app/Exceptions/Handler.php. You should compare yours against the Laravel 5.5 version and merge these changes manually.

@driesvints
Copy link
Member Author

ℹ In Laravel 5.5, the Request has() method returns true for empty strings and null. If you would like to preserve the old behavior of the has() method, you may use the new filled() method instead.

@driesvints
Copy link
Member Author

ℹ In Laravel 5.5, the Request only() method returns attributes that are actually present in the request payload. If you would like to preserve the old behavior of the only() method, you may use the all() method instead.

@driesvints
Copy link
Member Author

driesvints commented Oct 12, 2017

❌ Shift could not upgrade the following project files since they differed from the default Laravel version. You will need to compare these project files against the default Laravel 5.5 versions and merge any changes:

  • phpunit.xml
  • public/index.php
  • public/.htaccess
  • tests/Feature/ExampleTest.php

@driesvints
Copy link
Member Author

driesvints commented Oct 12, 2017

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.5 configuration files and merge any changes:

  • config/mail.php
  • config/services.php

@driesvints
Copy link
Member Author

ℹ Laravel 5.5 now sets the session cookie name using the APP_NAME. If you rely on the previous laravel_session value, you may set this using the new SESSION_COOKIE environment variable. Review the cookie key in config/session.php for more details.

@driesvints
Copy link
Member Author

❌ Laravel 5.5 requires PHP 7. You have a modified dependency for PHP in your composer.json. Ensure it meets the new version requirement of >=7.0.0.

@driesvints
Copy link
Member Author

❌ Laravel 5.5 has a development dependency for phpunit/phpunit of ~6.0. You have a modified dependency for phpunit/phpunit in your composer.json. Ensure it meets the new version requirement of ~6.0.

@driesvints
Copy link
Member Author

⚠ Shift detected you are using the Laravel BrowserKit Testing package. Laravel changed its testing layer in Laravel 5.4. Once you have verified this upgrade, you can use the Laravel 5.4 Tests Shift to upgrade your tests to the new Laravel testing layer.

@driesvints
Copy link
Member Author

ℹ Laravel 5.5 changed the default format for HTTP exception responses. This may affect your application if you rely upon default JSON responses. Review the Exception Format section of the Upgrade Guide for more detail.

@driesvints
Copy link
Member Author

ℹ Laravel 5.5 removed bootstrap/autoload.php and uses the Composer vendor/autoload.php instead. If you were referencing bootstrap/autoload.php directly, you should upgrade your application accordingly.

@driesvints
Copy link
Member Author

ℹ If you are using the database cache driver, you should run php artisan cache:clear when running your upgraded Laravel 5.5 application for the first time.

@driesvints
Copy link
Member Author

ℹ Laravel 5.5 uses package auto-discovery to make it easier to install and enable packages. This may require you to update Composer. You may do so by running composer self-update. Review the Composer documentation for more details.

@driesvints
Copy link
Member Author

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.

@driesvints
Copy link
Member Author

driesvints commented Oct 12, 2017

❌ PHP syntax errors were detected after running your Shift. Often these are misplaced lines due to an unexpected code format.

I found PHP syntax errors in:

  • app/Models/Thread.php

@driesvints driesvints merged commit 4e52601 into master Oct 12, 2017
@driesvints driesvints deleted the shift-4820 branch October 12, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants