-
-
Notifications
You must be signed in to change notification settings - Fork 658
Laravel 8.x Shift #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 8.x Shift #563
Conversation
The Laravel framework adopts the PSR-2 coding style with some additions. Laravel apps *should* adopt this coding style as well. However, Shift allows you to customize the adopted coding style by adding your own [PHP CS Fixer][1] `.php_cs` config to your project. You may use [Shift's .php_cs][2] file as a base. [1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer [2]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them. This allows you to review the commit diff for once for customizations when you are done Shifting. Moving forward, consider using ENV variables or create a separate config file to allow the core config files to remain as default as possible.
❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 8 versions and merge any changes:
|
ℹ️ Laravel 8 streamlined the Exception Handler into a single While this change is not required, Shift recommends comparing yours against the Laravel 8.x version as an opportunity to reduce code and be fully up-to-date. |
❌ To match the other auth middleware, Laravel 8 now allows multiple guards for the Shift attempted to automate these changes, but detected customizations. You will need to compare your |
ℹ️ The You may automate the conversion to static class references using the Shift Workbench. |
❌ Laravel 8 condenses the |
ℹ️ Laravel 8 introduced class based factories. Shift automated this change. However, if you were using a community package for factories or other custom code, you should review your factories for additional changes. If you encounter an issue, you may revert this commit and temporarily install the laravel/legacy-factories package. You may then automate the conversion to class based factories using the Shift Workbench. |
ℹ️ Laravel 8 added a If your application is currently using the php artisan make:migration AddUuidToFailedJobsTable Then copy and paste the contents from Shift's |
ℹ️ Laravel 8 added a new ENV variable of |
You should review this commit for any additional customizations. If you have a lot of customizations, you may wish to undo this commit with |
ℹ️ Shift detected a dependency for Shift did not update your dependency as it is compatible with Laravel 8. |
ℹ️ Shift updated your dependencies for Laravel 8. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 8. Watch dealing with dependencies for tips on handling package incompatibilities. |
|
\Illuminate\Pagination\Paginator::useBootstrap(); |
|
🎉 Congratulations, you're now running the latest version of Laravel. The following Shifts may be used ensure your application is fully upgraded and easier to maintain in the future:
You may run these Shifts and stay upgraded forever as well by subscribing to a Shifty Plans. |
@driesvints I think this is good to go |
database/migrations/2020_11_03_205735_add_uuid_to_failed_jobs_table.php
Outdated
Show resolved
Hide resolved
database/migrations/2020_11_03_205735_add_uuid_to_failed_jobs_table.php
Outdated
Show resolved
Hide resolved
@joedixon just a few remarks. |
@driesvints pinging you here as I can't add request a review as it's your PR. Made all changes except the one I commented on above. |
How's that? |
Perfect. Thanks Joe! |
This pull request includes the changes for upgrading to Laravel 8.x. Feel free to commit any additional changes to the
shift-35839
branch.Before merging, you need to:
shift-35839
branchcomposer update
(if the scripts fail, add--no-scripts
)If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.