Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lark.lark parse the same grammar as load_grammar.py, and make grammar.md document it more fully. #1388
base: master
Are you sure you want to change the base?
Make lark.lark parse the same grammar as load_grammar.py, and make grammar.md document it more fully. #1388
Changes from all commits
db1a5a5
9493f81
7a2880f
83a374f
fdffb5f
95c5742
200d6b5
0fb28f9
2ec5ef3
e9c026e
9bf7ddf
7f02bd1
4f7a5eb
40576d2
daac65d
5f37365
697841b
654e102
33d7088
0d01fe2
20302ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
priority
is already optionalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but
load_grammar.py
sayspriority
is a required element ofrule
, and thatpriority
is_DOT NUMER
or null. I wantedlark.lark
to produce the same parse tree asload_grammar.py
.It's different for
token
(term
inload_grammar.py
) - there,load_grammar.py
[sayspriority
is optional[(https://github.com/lark-parser/lark/blob/master/lark/load_grammar.py#L162-L163).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erezsh If my comment of 2024-06-20 is acceptable, let's resolve this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what I meant was that priority can already be an empty rule, so no point in making it optional.