Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints update #175

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Type hints update #175

merged 3 commits into from
Jun 8, 2020

Conversation

timdebruin
Copy link
Contributor

This makes multi-stage training compatible with newer zookeeper versions

Copy link
Contributor

@AdamHillier AdamHillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 👍

@lgeiger lgeiger added the bug Something isn't working label Jun 8, 2020
Co-authored-by: Lukas Geiger <lgeiger@users.noreply.github.com>
Co-authored-by: Lukas Geiger <lgeiger@users.noreply.github.com>
@lgeiger lgeiger requested a review from AdamHillier June 8, 2020 16:38
@lgeiger
Copy link
Member

lgeiger commented Jun 8, 2020

Thanks for the fix. The test failure of #174 might be caused by this as well.

@lgeiger lgeiger added bug Something isn't working and removed bug Something isn't working labels Jun 8, 2020
@timdebruin timdebruin merged commit c9e96a3 into master Jun 8, 2020
@timdebruin timdebruin deleted the zookeeper-compatibility branch June 8, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants