Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it general #40

Merged
merged 7 commits into from
Aug 8, 2019
Merged

Make it general #40

merged 7 commits into from
Aug 8, 2019

Conversation

jamescook106
Copy link
Contributor

No description provided.

@jamescook106
Copy link
Contributor Author

@lgeiger please review the docstrings and the modified test I put in, and then we can swap from draft and get an additional reviewer

@jamescook106 jamescook106 marked this pull request as ready for review August 8, 2019 12:59
@jamescook106 jamescook106 added the feature New feature or request label Aug 8, 2019
Copy link
Contributor

@MariaHeuss MariaHeuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the documentation in the Preprocessing class this all looks good to me.

@jamescook106
Copy link
Contributor Author

@MariaHeuss I have updated the doc strings as per your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants