Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change component colouring in __repr__ #91

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Change component colouring in __repr__ #91

merged 1 commit into from
Jan 6, 2020

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jan 6, 2020

This PR slightly changes the coloured string representation. It removes the spacing for the keyword arguments and makes the printing multicolour:

master

Screenshot 2020-01-06 at 10 59 17

PR

Screenshot 2020-01-06 at 11 05 02

@lgeiger
Copy link
Member Author

lgeiger commented Jan 6, 2020 •
edited
Loading

Thinking about this again, it would be even nicer to use proper Python syntax highlighting. prompt-toolkit has support for this already. Though this is not something we need to look into right now.

AdamHillier
AdamHillier approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@AdamHillier AdamHillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nicer, thanks :)

@AdamHillier AdamHillier merged commit cc26fd8 into master Jan 6, 2020
@AdamHillier AdamHillier deleted the colors branch January 6, 2020 10:57
@AdamHillier AdamHillier mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamHillier AdamHillier AdamHillier approved these changes

Assignees
No one assigned
Labels
internal-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgeiger @AdamHillier