Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to recent bundler #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tim-vandecasteele
Copy link

The latest bundler doesn't reload the environment when load.specs is called (it's memoized), so the gemfile option is not respected.

Update to recent bundler, and make it possible to use the same gemfile for the complete project and the specific ocra executable.

You can now refer to a gemfile that is structured with groups and only include the gems that are relevant (in the below case ‘tiny_tds’)

source 'https://rubygems.org'
group :development do
gem 'pry'
gem ‘ocra’
end
gem 'tiny_tds'

I also changed that including the gemfile would not check the loaded gems, as in my usecase this would include additional gems I don't use in the executable (for example ocra itself).

…e for the complete project and the specific ocra executable.

You can now refer to a gemfile that is structured with groups and only include the gems that are relevant (in the below case ‘tiny_tds’)

source 'https://rubygems.org'
group :development do
  gem 'pry'
  gem ‘ocra’
end
gem 'tiny_tds'
@larsch
Copy link
Owner

larsch commented Nov 22, 2015

Thanks for the submission, but I have tried with Bundler 1.10.6 and Ruby 2.2.3p173 and can't reproduce any issue. Can you provide more details and a test-case or example that doesn't work?

@larsch larsch force-pushed the master branch 2 times, most recently from b897a6e to 2e7c88f Compare December 1, 2015 12:23
@tim-vandecasteele
Copy link
Author

I'm using bundler 1.11.2, but ruby 2.1.7.

I'll try to make a test project to show the behaviour.

Do you think the "groups" are a good idea? (group :development do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants