Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix author parsing in Wikidata: Again! (the same, but different, but still the same) #45

Closed
larsgw opened this issue May 11, 2017 · 1 comment
Assignees
Labels
bug Something isn't working right refactor Requests not impacting main APIs

Comments

@larsgw
Copy link
Owner

larsgw commented May 11, 2017

Parsing an entire set of entity data is fine, parsing a single prop (author by string or by Wikidata ID, P2093 and P50 respectively) is not. Also, the code to merge both author types is about half of the code of the method. Should be able to be done easier.

This is both a code-enhancement (because the general code looks ugly) and a bug, the latter because the method (not the code) to parse a prop is now exposed to the public and should be able to be used independently of the method to parse a full entity.

@larsgw larsgw added bug Something isn't working right refactor Requests not impacting main APIs labels May 11, 2017
@larsgw larsgw self-assigned this May 11, 2017
@larsgw
Copy link
Owner Author

larsgw commented May 19, 2017

Not a duplicate of #19, basically an improvement to the lazy fix for #21.

same, but different, but still same

@larsgw larsgw closed this as completed in e2edcdd Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right refactor Requests not impacting main APIs
Projects
None yet
Development

No branches or pull requests

1 participant