Gentoo patches #7
Conversation
|
Thanks & sorry for the late response, the email from github was sorted into spam. First of all, everything compiles and works after locally merging the pull request, and most changes look good to me. But I don't understand and hence disagree with the "fax compatibility" patch. According to ftp://ftp.avm.de/develper/capispec/capi20/capi20-3.pdf, a CIP Value of 4 means "3.1 kHz Telephony", and 17 means "Group 2/3 facsimile". So the original matches the spec, while the Gentoo patch doesn't seem to. Have you got an idea what made this patch necessary? |
|
Hi, I don't have a clue why this patch is part of the Gentoo ebuild. |
|
About fax compatibility patch, i was unable to contact with person who added this patch. But, looking into cvs history [1], i discover why it was added [2]. Hope this helps. For me it looks like some kind of workaround, but i am not familiar with fax software at all - just trying to support nearly abandonded net-dialup/ software category in Gentoo. [1] - http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-dialup/capisuite/files/capisuite-fax-compatibility.patch?view=log |
|
The “patch” was given by Gernot Hillier himself (http://osdir.com/ml/linux.isdn.capisuite.user/2004-05/msg00043.html) but obviously he never put it into the source. I think the best would be to leave it as Gentoo patch. Maybe it could be applied depending on a USE flag… So, I will remove it now and update the pull request. |
|
I reverted the “fax compatibiliy” patch. Please review again. |
This reverts commit 3413f4c. The patch was originally from Gernot Hillier for patching a problem with incompatible fax receivers [1]. It violates the CAPI specifications and therefore should not be included [2]. [1] http://osdir.com/ml/linux.isdn.capisuite.user/2004-05/msg00043.html [2] larsimmisch#7 (comment)
This reverts commit 3413f4c. The patch was originally from Gernot Müller for patching a problem with incompatible fax receivers [1]. It violates the CAPI specifications and therefore should not be included [2]. [1] http://osdir.com/ml/linux.isdn.capisuite.user/2004-05/msg00043.html [2] #7 (comment)
|
I've merged the pull request manually after testing. Thanks! |
These are all the Gentoo patches from capisuite-0.4.5-r8 ebuild applied to the current master. Except the ones that already were covered by capisuite development.
I do not know if these patches are necessary or break something on non-Gentoo machines.
Please let me know if I have to do more things to let this pull request being merged.
Please send questions to the reasons for the individual patches via e-mail to the Gentoo maintainer (Mr. Popov) and me.