Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown in Comments and Summary #186

Merged
merged 12 commits into from
Feb 16, 2014
Merged

Markdown in Comments and Summary #186

merged 12 commits into from
Feb 16, 2014

Conversation

vanev
Copy link
Contributor

@vanev vanev commented Feb 13, 2014

Users can use Markdown in post comments or summaries.

[via #106]

@treygriffith
Copy link
Collaborator

@evsie001 To fix the security risk you mentioned in #106 I think you just need to set the sanitize option to true, either with marked.setOptions or inline with the marked function call. See here: https://github.com/chjj/marked#sanitize

@vanev
Copy link
Contributor Author

vanev commented Feb 13, 2014

Consider that markdown sanitized.

@travishorn
Copy link
Contributor

It's worth considering other options for marked such as the block and inline level renderer methods. It might be necessary to disable certain methods such as heading, hr, table, image, etc. for fear that the submissions and comments could get out of hand with huge text or images.

@megamattron
Copy link
Member

Would you mind rebasing for me please? A bit of a nasty conflict at the end of show.jade I'm not quite sure about.

@vanev
Copy link
Contributor Author

vanev commented Feb 15, 2014

Everything should be all rebased and clean. Thanks, friends.

@sriehl
Copy link
Contributor

sriehl commented Feb 16, 2014

Thank YOU for adding this feature. Can't wait for it to be merged.

megamattron added a commit that referenced this pull request Feb 16, 2014
Markdown in Comments and Summary
@megamattron megamattron merged commit 2671cdf into larvalabs:master Feb 16, 2014
@megamattron
Copy link
Member

Sweet, it's in! I think it might be failing jshint checks, but we can deal with that now that it's in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants