Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify links in comments #106

Closed
megamattron opened this issue Feb 10, 2014 · 7 comments
Closed

Linkify links in comments #106

megamattron opened this issue Feb 10, 2014 · 7 comments

Comments

@megamattron
Copy link
Member

No description provided.

@vanev
Copy link
Contributor

vanev commented Feb 10, 2014

URI.js would be awesome for this. I can throw together a pull request tonight unless someone beats me to it.

@treygriffith
Copy link
Collaborator

Also, what about a more general solution to text formatting in comments, like markdown?

@josephwegner
Copy link
Collaborator

+1 for markdown. But you'd probably want a modified parser rather than the generic ones - a lot of markdown elements don't make sense in a comment (h1-3, img)

@ghost
Copy link

ghost commented Feb 12, 2014

The marked lib. looks like a good fit -- the gfm option seems somehow appropriate -- and it allows you to directly override renderer methods.

@vanev
Copy link
Contributor

vanev commented Feb 13, 2014

@cgroner, took your advice on marked. It looks great.

Only concern with Jade is that you need to use != which drops raw HTML. That seems like a security thing.

@kennethrapp
Copy link
Contributor

Might be too late but why not leave markdown parsing to the browser? Then you can leave everything escaped however you want.

@josephwegner
Copy link
Collaborator

Markdown is in, which includes linking... Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants