Fix for PDU's arriving in random order. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,7 +378,7 @@ function longSms(pduObj) { | |||
| // 4th octet and length is | |||
| // header size -2 octets | |||
| partsCount = pduObj.params.short_message[2 + csmsReference.length + 1], | |||
| partNr = pduObj.params.short_message[2 + csmsReference.length + 1], | |||
| partNr = pduObj.params.short_message[2 + csmsReference.length + 2], | |||
There was a problem hiding this comment.
This will only work for UDH headers that are 2 in size, right?
Don't we need to use the UDH size instead of hardcoded 2 here?
There was a problem hiding this comment.
I have generalized it so it would work for both. So in case scenario from the referred document
would be like following.
- First "2" is skipping the first 3 octets which remain constant
- csmsReference.length is the UDH size which we skip
- then we need to skip total parts count field which is 1 octet and then comes the actual partNr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9