added the ability to have environment sections. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def to_hash | ||
| build_hash_from_enviroment | ||
| end | ||
|
|
There was a problem hiding this comment.
Below should prob be private :/
|
following up. :) (I will rebase now) |
…LS_ENV or RACK_ENV is set, any enumerable hash value is excluded from the yaml file. Values which are enumerable are mashed over the top level hash if the current env matches the top level key
|
..and I broke tests. I will fix them soon, but still any feedback about how I could make this nicer for you would be appreciated. |
|
Sorry for the slow response. Have been busy trying to close on a house. Will get to this as soon as I'm able. Thanks for the contribution! |
|
Closing this because something better made it to master. thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default, if no RAILS_ENV or RACK_ENV is set, any enumerable hash value is excluded from the yaml file. Values which are enumerable are mashed over the top level hash if the current env matches the top level key.
I added to your cucumber suite, and did a bad thing by putting another class in your railite. :/
I am more than happy to move it out, as well as write unit tests, but seeing as rspec/minitest/whatever was not set up, I figure that would be something we could manage later.
Any and all suggestions welcome.