Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumed bug in preprocess_ids #9

Closed
etsnok opened this issue Jan 27, 2022 · 1 comment
Closed

Assumed bug in preprocess_ids #9

etsnok opened this issue Jan 27, 2022 · 1 comment

Comments

@etsnok
Copy link

etsnok commented Jan 27, 2022

In ontologies_embeddings.py in the method preprocess_ids, I assume that it's intended to collect the list of all ontology parents/ancestors. But wat it does instead is to take only the last ancestor. I guess correct would be something like:

 idxs.append(id_to_index[d.replace('_', ':')])
@dpavot
Copy link
Member

dpavot commented Feb 18, 2022

@etsnok yes! Great find. I updated the file!

@dpavot dpavot closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants