Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to pass las content directly #14

Merged
merged 2 commits into from
Apr 15, 2020
Merged

feat: add option to pass las content directly #14

merged 2 commits into from
Apr 15, 2020

Conversation

SkeLLLa
Copy link
Contributor

@SkeLLLa SkeLLLa commented Apr 13, 2020

I've added second argument to constructor with options. So it will make possible to pass las file contents directly in browser as well. And also it will be easy to extend in future.

Closes #13

Copy link
Member

@iykekings iykekings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @SkeLLLa, glad you added default loadFile value, so it is still backward compatible.

Copy link
Contributor

@MartinsOnuoha MartinsOnuoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, code level.

@MartinsOnuoha
Copy link
Contributor

Looks good to me, code level.

Great work 🎉
@SkeLLLa do you think you could squash both commits into one? so there's just one commit

@iykekings iykekings merged commit ded9277 into laslibs:master Apr 15, 2020
@SkeLLLa SkeLLLa deleted the feat/accept-raw-las-string branch April 16, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add ability to pass buffer to constructor
4 participants