Share button [1/n]: Create button UI #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
This was referenced Jan 25, 2024
Doesn't do anything when you click it now, but just setting up the UI and tooltip. Will add upload feature next PR ## Test Plan Run these commands from the `aiconfig` dir: ```bash aiconfig_path =./cookbooks/Gradio/huggingface.aiconfig.json parsers_path=./cookbooks/Gradio/hf_model_parsers.py aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` <img width="1512" alt="Screenshot 2024-01-25 at 15 58 42" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/6f414df7-dcf3-4b58-beed-c4fc3f7c2968">
rholinshead
reviewed
Jan 25, 2024
| @@ -940,6 +940,20 @@ export default function AIConfigEditor({ | |||
| <Container maw="80rem"> | |||
| <Flex justify="flex-end" mt="md" mb="xs"> | |||
| <Group> | |||
| {/* TODO: Remove false gating below once Share button is ready */} | |||
| {false && !readOnly && ( | |||
There was a problem hiding this comment.
Let's also make this predicated on a 'getShareLink' callback existing so that we only show this in gradio (where we can pass through the function implementation that calls gradio backend)
There was a problem hiding this comment.
Can be done in later PR
There was a problem hiding this comment.
so that we only show this in gradio
I was thinking of just using MODE, but yea this works too
Let's also make this predicated on a 'getShareLink' callback existing
Yea I have this planned for a future PR
rholinshead
approved these changes
Jan 25, 2024
rossdanlm
added a commit
that referenced
this pull request
Jan 26, 2024
…#1032) Move !readOnly check to entire header grouping at top for all buttons Doing this makes it easier to manage rather than gating each one individually ## Test Plan No functional changes ReadOnly mode <img width="1512" alt="Screenshot 2024-01-25 at 16 03 30" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/3493b525-e943-46fe-805d-3424af206bae"> Regular mode (with share button shown) <img width="1512" alt="Screenshot 2024-01-25 at 16 04 06" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/fc7a86c2-8efb-4190-afe9-870a15e93f46"> --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1032). * #1037 * #1035 * __->__ #1032 * #1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share button [1/n]: Create button UI
Doesn't do anything when you click it now, but just setting up the UI and tooltip. Will add upload feature next PR
Test Plan
Run these commands from the
aiconfigdir:Stack created with Sapling. Best reviewed with ReviewStack.