backtrace--print-frame was deleted in emacs 27+, use alternate. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastquestion
force-pushed
the
fix-emacs-27-report-bug
branch
from
dbc4147
to
aaea3ad
Compare
lastquestion
force-pushed
the
fix-emacs-27-report-bug
branch
from
aaea3ad
to
e5e0a40
Compare
|
I tried to make this more elegant via some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been caught via unit tests, and it did, I just didn't actually set the env-var for the unit test run correctly. I will automate that in another PR.
I decided to
(require 'backtrace)dynamically, only when we actually need it, as it's not defined in emacs 26. In some future world when 26 support is dead (4 years from now?) I will move it to the top level requires.The commit is emacs-mirror/emacs@83af893