Define clearBoth class

[scottcwilson]

This class is used in a number of template files, both in bootstrap and template_default, so it needs to be defined.

[lat9]

What is the underlying issue being corrected by this change?

[scottcwilson]

• clearBoth is referenced but not defined.
• clearfix is referenced but not defined - but it's a duplicate.
  You can see the impact of not having a clearBoth definition by attempting to use it to clear floats- it won't clear them.

So if you do a clearboth and then add some text right underneath it (for example), the text will still be floated just like the item before it.

Prob easiest way to see is just put some content on an ezpage, float some things, do a clearboth and then add some content underneath that. You'll see the floats are not cleared.

[scottcwilson]

Here's a way to dup the issue: If you modify bootstrap's version of tpl_product_info_display.php to add some text right after the clearBoth following Ask a Question, you'll see the text is still floated.

[lat9]

There needs to be a way to get that to render properly using clearfix. One of the tenets of the BootStrap template instituted by Ray Barbour is that the stylesheet.css is kept to a minimum and the Bootstrap classes are maintained.

[scottcwilson]

Right now there are 43 references to clearBoth in bootstrap/templates, but this class is not defined so it won't work the way people expect. You could change all clearBoth classes to clearfix, but then you'd still be in trouble if template_default had a template which was not overridden that referred to clearBoth. I think my fix is the least intrusive but it's your call.

[lat9]

I can see the need for defining the clearBoth style, but I'm still not convinced that the associated template changes are required. I'm open to the change if you can show me something that's not working.

[scottcwilson]

Nah, I'll back that out. So now the PR has just the CSS change.