Add OpenID Connect Token authenticator #167
Conversation
puiterwijk
force-pushed
the
oidcauthn
branch
2 times, most recently
from
cf4aabe
to
bdc2a78
Compare
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 60.02% 59.48% -0.54%
==========================================
Files 36 36
Lines 3042 3083 +41
Branches 338 345 +7
==========================================
+ Hits 1826 1834 +8
- Misses 1126 1159 +33
Partials 90 90
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| class OpenIDCTokenAuth(HTTPAuthenticator): | ||
| token_info_url = PluginOption(str, None, |
There was a problem hiding this comment.
You can use REQUIRED to make an option mandatory
| return False | ||
| elif request.get('access_token'): | ||
| self.logger.debug('Token provided in form') | ||
| token = request.get('access_token') |
| self.logger.debug('Missing any credentials in request') | ||
| return False | ||
|
|
||
| if not token: |
There was a problem hiding this comment.
Is it necessary to check token again?
|
|
||
| try: | ||
| tokeninfo = self._get_token_info(token) | ||
| except: |
There was a problem hiding this comment.
Please don't use a bare except. except Exception
| scope = PluginOption(str, 'custodia', 'OAuth2 scope to require') | ||
|
|
||
| def _get_token_info(self, token): | ||
| return requests.post(self.token_info_url, |
There was a problem hiding this comment.
Other plugins accept a CA cert argument to customize TLS verification. We could have global option for trusted CA cert, too.
| @@ -131,3 +133,62 @@ def handle(self, request): | |||
| self.audit_svc_access(log.AUDIT_SVC_AUTH_FAIL, | |||
| request['client_id'], dn) | |||
| return False | |||
|
|
|||
|
|
|||
| class OpenIDCTokenAuth(HTTPAuthenticator): | |||
There was a problem hiding this comment.
Please add a doc string with an example how to configure and use this plugin with e.g. Ipsilon.
Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com