Move more plugins to new configuration system #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,17 +10,15 @@ | |||
| from custodia.message.common import UnknownMessageType | |||
| from custodia.message.formats import Validator | |||
| from custodia.plugin import HTTPConsumer, HTTPError | |||
| from custodia.plugin import CSStoreError, CSStoreExists | |||
| from custodia.plugin import CSStoreError, CSStoreExists, PluginOption | |||
There was a problem hiding this comment.
This makes pep8py2 compain as the imports are in the wrong order.
There was a problem hiding this comment.
pep8py2 doesn't complain on my machine although I have the import order checker installed. Maybe you have a different version than 0.9.2? Your versions picks up the problem correctly (C > H > P).
tiran
force-pushed
the
plugin_config2
branch
from
7692cb4
to
2f7f760
Compare
|
Please rebase this on master, has conflicts after we pushed argparse and fixes for import order |
tiran
force-pushed
the
plugin_config2
branch
from
2f7f760
to
63cbea8
Compare
Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
plugin_config2
branch
from
63cbea8
to
aedbefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes cheimes@redhat.com