Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/openssl/hmac.c: avoid conflict with stdlib hmac on NetBSD #130

Merged
merged 1 commit into from
May 30, 2023
Merged

lib/openssl/hmac.c: avoid conflict with stdlib hmac on NetBSD #130

merged 1 commit into from
May 30, 2023

Conversation

nikkicoon
Copy link
Contributor

No description provided.

@nikkicoon
Copy link
Contributor Author

proposal for unblocking the build on NetBSD, a lengthier version of the patch we currently use in pkgsrc.
Shorter would probably be just renaming the function, if you're okay with that.

sarroutbi
sarroutbi requested changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

I prefer that the existing function is renamed. That way, we don't have duplicated code, which is more difficult to mantain.

We will have a jose release in the short term and we can include this.

@nikkicoon
lib/openssl/hmac.c: rename hmac function to jhmac
6cd9d03 
Avoid conflict with stdlib hmac(3) on NetBSD.
@nikkicoon
Copy link
Contributor Author

thanks! I renamed the function to jhmac.

@sarroutbi sarroutbi self-requested a review May 26, 2023 14:17
sarroutbi
sarroutbi approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. @sergio-correia : any further comment?

@sarroutbi sarroutbi self-requested a review May 26, 2023 15:00
sarroutbi
sarroutbi approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@sarroutbi sarroutbi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Change LGTM

@sarroutbi sarroutbi merged commit 33b9e0b into latchset:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-correia sergio-correia sergio-correia approved these changes

@sarroutbi sarroutbi sarroutbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikkicoon @sarroutbi @sergio-correia