Implement elementary .pem keyfile parsing.
#62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `jose jws sig -p ~/gcloud.pem -I payload.json`
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
- Coverage 77.75% 77.25% -0.5%
=========================================
Files 60 60
Lines 5794 5720 -74
=========================================
- Hits 4505 4419 -86
- Misses 1289 1301 +12
Continue to review full report at Codecov.
|
sarroutbi
requested changes
Oct 13, 2021
| } else { | ||
| FILE_AUTO *file = fopen(arg, "r"); | ||
| // TODO: encrypted key callback for password. | ||
| if (!(file && PEM_read_PrivateKey(file, &pkey, NULL, NULL))) |
There was a problem hiding this comment.
Here, it is not distinguished the case of !file vs the case of PEM_read_PrivateKey.
Distinguish between them, so that if the error has to do with PEM_read_PrivateKey, then fclose on file is done
| @@ -84,6 +84,12 @@ static const jcmd_doc_t jcmd_doc_key[] = { | |||
| {} | |||
| }; | |||
|
|
|||
| static const jcmd_doc_t jcmd_doc_pem[] = { | |||
| { .arg = "FILE", .doc="Import JWK from '.PEM' FILE" }, | |||
There was a problem hiding this comment.
is it required for the file to be ".PEM"? Why not just "Import JWK from FILE"?
| @@ -84,6 +84,12 @@ static const jcmd_doc_t jcmd_doc_key[] = { | |||
| {} | |||
| }; | |||
|
|
|||
| static const jcmd_doc_t jcmd_doc_pem[] = { | |||
| { .arg = "FILE", .doc="Import JWK from '.PEM' FILE" }, | |||
| { .arg = "-", .doc="Import JWK from '.PEM' on standard input" }, | |||
There was a problem hiding this comment.
I think "Import JWK from standard input" fits better
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively untested
.pemparsing for RS256, etc.Useful perhaps for RS256 per https://cloud.google.com/iot/docs/how-tos/credentials/jwts
See Also #39
Example
jose jws sig -I payload.json -p ~/gcloud.pemFile Contents
payload.jsongcloud.pem