Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull request template #362

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add pull request template #362

merged 1 commit into from
Mar 20, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Mar 19, 2024

No description provided.

@Jakuje
Copy link
Contributor Author

Jakuje commented Mar 19, 2024

Some open questions:

  • Do we need some more checks or hints?
  • Is there something to remove?
    • From the original I removed the checks for Sing-off trailers in the commits. I think that nothing that can be checked automatically as part of CI do not need to be listed again.

simo5
simo5 requested changes Mar 19, 2024
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@Jakuje
Add pull request template
5edb0fe 
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@simo5 simo5 merged commit f7d4da1 into latchset:main Mar 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jakuje @simo5