Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: No longer skip tests reading EC keys from cert #434

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Aug 22, 2024

Description

This condition was introduced at the time when we were running the softhsm under p11-kit proxy, which caused some issues to mac.

We no longer do this so there is no need to skip this test either.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

This condition was introduced at the time when we were running the
softhsm under p11-kit proxy, which caused some issues to mac.

We no longer do this so there is no need to skip this test either.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@Jakuje Jakuje marked this pull request as ready for review August 22, 2024 14:55
@simo5 simo5 added the covscan-ok Coverity scan passed label Aug 22, 2024
@simo5 simo5 merged commit fdaaf14 into latchset:main Aug 22, 2024
36 checks passed
@simo5
Copy link
Member

simo5 commented Aug 22, 2024

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
covscan-ok Coverity scan passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants