-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\graphicspath and trailing / #1076
Comments
I think this will be the dev release. I know what the reason will be. A bit of work but addressable. |
Ah, no, something arising from an earlier change. Anyway, I'll fix. |
Note that I’ll fix in expl3 |
Right, that should sort it: I'll wait for some team colleagues to take a look, and then aim for an |
@josephwright I've no objection to making this work without a trailing
https://github.com/latex3/latex2e/blob/develop/base/ltdirchk.dtx#L121 so documented as explicitly needing |
I tested this, |
I thought that was the case, but couldn't pin it down :) When I adjusted the |
the reason it was mandatory in 1993 was to avoid run time checking on how to combine directory and filename, but vms, atari, ... less of an issue now, so it's probably safe to insert a |
If the trailing / was required in the past and documented as requiring it, I wonder if we should make it more flexible if that means runtime checks throughout. The case is special enough in my opinion that a strict syntax is not a problem (and the fact that it worked for a little while neither). Just my 2 cents. |
just looked, making it flexible doesn't see so clostly, so I take it back. |
My original thinking was it was more effort than it was worth, but then @kberry popped up :) It's only a short loop and a quark test, I think we can live with it. |
I guess it was my (and your) misfortune to have a need for \graphicspath
during that window when it worked without slashes.
The documentation in grfguide does (did) not unambiguously state that
/'s are required, or that they're optional. Sure, the example there uses
/'s, but that is not the same as a clear statement, one way or the
other. "A list of directories" does not imply trailing slashes are
required.
So adding a sentence to that description in grfguide would be helpful,
IMHO. Sorry if already done, I didn't check dev sources. --best, karl.
|
The |
In the past it was not necessary to have an explicit / at the end of the elements of \graphicspath. As of the latest releases (not sure exactly when or what), it doesn't work unless the / is given. The documentation is not exactly clear on whether it's theoretically required, but since it's always worked before (I think). Trivial example:
will not find somefig.{jpg,png,pdf} in somedir.
The text was updated successfully, but these errors were encountered: