Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lthooks] Reorder generic hook names #648

Closed
PhelypeOleinik opened this issue Aug 13, 2021 · 0 comments
Closed

[lthooks] Reorder generic hook names #648

PhelypeOleinik opened this issue Aug 13, 2021 · 0 comments

Comments

@PhelypeOleinik
Copy link
Member

Brief outline of the enhancement

When developing lthooks we ended up with generic hooks named in two different ways: with the variable part in the second position as in env/<name>/before, and in the end, as in file/before/<name>. This difference makes it difficult to remember which is which, and makes for unnecessary complication in the code.

The plan here is to change all generic hooks to have the variable part in the second position in the name, so these hooks will be changed (hoping I didn't forget any):

Old name New name
file/before/<file> file/<file>/before
file/after/<file> file/<file>/after
package/before/<package> package/<package>/before
package/after/<package> package/<package>/after
class/before/<class> class/<class>/before
class/after/<class> class/<class>/after
include/before/<file> include/<file>/before
include/end/<file> include/<file>/end
include/after/<file> include/<file>/after

A deprecation cycle will be provided so that the old names still work for some time, to allow adjustments without compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants