Gh648 [lthooks] Standardise generic hook names #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test catches hooks like 'file/after' as well as 'file/<name>/after', so both subcomponents have to be tested
Now the generic hook declaration just doesn't happen for misnamed hooks
Makes the whole code (especially \use_hook:n) much simpler
\@@_if_structure_exist:nTF instead of \@@_if_usable:nTF, because we want to add code to it, and not use it. This also makes checking for deprecation unnecessary (already done in \@@_try_declaring_generic_next_hook:nn)
FrankMittelbach
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #648. The generic hook names are reordered so that the variable part is in the middle position (
package/foo/beforeinstead ofpackage/before/foo) to matchenvandcmdhooks. A deprecation fallback is provided so that the old names still work normally (with a warning) so that people have time to adjust.Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated