Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.
Pull requests in this repository are intended for LaTeX Team members only.
\luafunction
only defines a number register, while most uses of it actually end up defining a lua command using\luadef
. This adds unnecessary indirection and requires an additional csname for the index. Therefore this adds\newluacmd
and\newprotectedluacmd
to combine the index allocation and the following\luadef
.Open questions:
\countdef
with\newcount
would lead to\newlua
, but that seems overly generic. Alternativly we could use\newluadef
butdef
suggests that the index is explicitly given. IMO\newluacmd
sounds good, butluacmd
isn't a name which is used anywhere else.protected
. This is consistent with the underlying engine, but we might prefer to default to being unexpandable instead and using e.g.\newexpandableluacmd
for the other one as for e.g. xparse. Alsoprotected
might be misleading since these commands really act like unexpandable primitives and are not semi-expandable like\protected
macros.Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
updated