This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
More robust install.sh #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing that! Can someone test this and confirm that it works? |
dyc3
suggested changes
Dec 10, 2019
This was referenced Dec 10, 2019
|
Made all commented changes, but also fixed #96 by changing the torrent URL. |
|
Lol I'm not a shell wizard either, but this does look pretty good. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ./install.sh is pretty lacking and requires a lot of user intervention. I've tried to make it more robust and support several Linux distros other than Ubuntu/Debian.
I'm currently using EndeavourOS (Arch based) and we're on Python 3.8. Tensorflow 1.15 only works up to Python 3.6.
Because of this, I added a check to see what version of Python you're on. If you're not on 3.6 it'll ask you to manually install it (no way I was going to try to manage that.) or it allows you to enter a manual path for pip3.6.
Also during my testing, it was annoying that the script just assumed I didn't have any problems if it found ./generator/gpt2/models so now it asks if you want to reinstall.
I've tested this script in several different ways and it has passed all of my tests, but I don't have any other distros installed to try it out on.
I'm not going to pretend I'm a Bash wizard so any feed back is appreciated.