Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve devcontainer.json #1056

Closed
wants to merge 1 commit into from
Closed

Conversation

roninjin10
Copy link
Contributor

Copy paste in some improvements to the devcontainer from evmts added by @o-az

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 277fbdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title feat: Improve devcontainer.json build: improve devcontainer.json Jun 20, 2023
Comment on lines +30 to +32
"files.associations": {
".gas-snapshot": "julia"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this one?

"ghcr.io/devcontainers/features/git": {},
"ghcr.io/devcontainers/features/github-cli": {}
},
// TODO which other ports do we include here?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the vite dev client port? (should be 3000)

Comment on lines +28 to +29
// TODO get correct version
"solidity.compileUsingRemoteVersion": "v0.8.17",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to have "logic" in this json that grabs the solidity version from somewhere?

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! generally down to merge this as is, just had some minor comments

@holic
Copy link
Member

holic commented Mar 11, 2024

closing for now as this is out of date, feel free to open a new PR or reopen this one with updates

@holic holic closed this Mar 11, 2024
@roninjin10
Copy link
Contributor Author

I have no memory of making this pr lol

@holic
Copy link
Member

holic commented Mar 11, 2024

9 months in internet time is an eternity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants