-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: improve devcontainer.json #1056
Conversation
Copy paste in some improvements to [the devcontainer from evmts](https://github.com/evmts/evmts-monorepo/blob/main/.devcontainer/devcontainer.json) added by @o-az
|
"files.associations": { | ||
".gas-snapshot": "julia" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this one?
"ghcr.io/devcontainers/features/git": {}, | ||
"ghcr.io/devcontainers/features/github-cli": {} | ||
}, | ||
// TODO which other ports do we include here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the vite dev client port? (should be 3000)
// TODO get correct version | ||
"solidity.compileUsingRemoteVersion": "v0.8.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to have "logic" in this json that grabs the solidity version from somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool! generally down to merge this as is, just had some minor comments
closing for now as this is out of date, feel free to open a new PR or reopen this one with updates |
I have no memory of making this pr lol |
9 months in internet time is an eternity |
Copy paste in some improvements to the devcontainer from evmts added by @o-az