Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-indexer): use fastify, move trpc to /trpc #1232

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Conversation

holic
Copy link
Member

@holic holic commented Aug 3, 2023

cc @roninjin10 (since this is a prereq for trpc panel)

puts fastify server in front of trpc and moves trpc endpoints to /trpc, which will let us add other top-level endpoints like trpc panel, other frontends (grpc) etc

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 6cbe694

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/store-indexer Major
@latticexyz/block-logs-stream Major
@latticexyz/cli Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review August 3, 2023 09:21
@holic holic requested a review from alvrs as a code owner August 3, 2023 09:21
@holic holic requested a review from roninjin10 August 3, 2023 09:21
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy 6 to 20s?!?! That's nuts

packages/store-indexer/bin/sqlite-indexer.ts Show resolved Hide resolved
packages/store-indexer/bin/sqlite-indexer.ts Show resolved Hide resolved
holic and others added 2 commits August 3, 2023 08:35
Co-authored-by: Will Cory <willcory10@gmail.com>
Co-authored-by: Will Cory <willcory10@gmail.com>
@holic holic changed the title feat(store-indexer): use fastify, move trpc to /trpc, enable compression feat(store-indexer): use fastify, move trpc to /trpc Aug 11, 2023
alvrs
alvrs previously approved these changes Aug 15, 2023
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a changeset with context for this change (also curious myself, what's the advantage of fastify?)

@holic
Copy link
Member Author

holic commented Aug 15, 2023

what's the advantage of fastify?

you can think of it like express, but more modern and faster

@holic holic merged commit b621fb9 into main Aug 15, 2023
9 checks passed
@holic holic deleted the holic/indexer-gzip branch August 15, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants