-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-indexer): use fastify, move trpc to /trpc #1232
Conversation
🦋 Changeset detectedLatest commit: 6cbe694 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy 6 to 20s?!?! That's nuts
Co-authored-by: Will Cory <willcory10@gmail.com>
Co-authored-by: Will Cory <willcory10@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a changeset with context for this change (also curious myself, what's the advantage of fastify?)
you can think of it like express, but more modern and faster |
cc @roninjin10 (since this is a prereq for trpc panel)
puts fastify server in front of trpc and moves trpc endpoints to
/trpc
, which will let us add other top-level endpoints like trpc panel, other frontends (grpc) etc